lkml.org 
[lkml]   [2008]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] Remove BKL from the bfs driver
On Thu,  5 Jun 2008 21:26:35 +0300
Dmitri Vorobiev <dmitri.vorobiev@movial.fi> wrote:

> This removes quite a few instances of BKL usage in the bfs
> driver. Given the purpose and the user base of this driver,
> I do not believe that a finer-granularity lock than the big
> fat filesystem-wide mutex I have implemented here is needed.

How well tested was this? With lockdep enabled?

Because the new mutex cannot be taken recursively, whereas the BKL can.
And there's potential for ab/ba deadlocks with, for example, i_mutex.

However I don't see any such problems from a moderately intensive
review.


\
 
 \ /
  Last update: 2008-06-05 20:49    [W:0.051 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site