lkml.org 
[lkml]   [2008]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [parch 4/4] vfs: utimensat(): fix write access check for futimens()
From
Date
> On Wed, Jun 4, 2008 at 7:54 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> >> At which point the "if (f)" and the "else" branches become equivalent
> >> (the nameidata isn't interesting in the other case either). So that
> >> could be written as:
> >>
> >> if (!is_owner_or_cap(inode)) {
> >> error = permission(inode, MAY_WRITE, NULL);
> >> if (error)
> >> goto mnt_drop_write_and_out;
> >> }
> >
> > And also the IS_IMMUTABLE() check can be removed, since it's checked
> > by permission(MAY_WRITE) anyway.
>
> I'm not sure that that is true, because immutability applies
> regardless of capabilities or ownership, right?

Yeah, you're right. I misread that.

Miklos


\
 
 \ /
  Last update: 2008-06-04 10:47    [W:0.332 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site