Messages in this thread | | | Date | Wed, 04 Jun 2008 19:53:48 +0900 | From | Hidehiro Kawai <> | Subject | Re: [PATCH 1/5] jbd: strictly check for write errors on data buffers |
| |
Hi,
Andrew Morton wrote:
> On Mon, 02 Jun 2008 19:43:57 +0900 > Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> wrote: > >>In ordered mode, we should abort journaling when an I/O error has >>occurred on a file data buffer in the committing transaction. > > Why should we do that?
Aborting the journal leads the filesystem to read-only state, and it can prevent inconsistent state in file data from diffusing furthermore. I think it makes sense for ordered mode users; they don't want to lose file updates as much as possible, but they don't want to do fsync.
Thanks, -- Hidehiro Kawai Hitachi, Systems Development Laboratory Linux Technology Center
| |