lkml.org 
[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 12/60] microblaze v4: Generic dts file for platforms
    Hi John, Steve and others,

    in generic platform will be generic DTS which I sent in first versions.
    This DTS will be for simple platform. There is not copyright.

    FDT generator add copyright notice on the top of file. I added it when I start
    to program this BSP. Xilinx only add their copyright line which is fine.
    We can talk how big can be this copyright but I am convinced that will be
    part of commented code forever because there is placed important information
    which EDK version this file generated and which version of FDT this file generate.
    We can talk about showing license there but I think this is out of topic now because there
    won't be any license in first microblaze pack.

    Michal

    > Since this is a generated file, and entirely bitstream specific, does
    > it make sense to include it in the kernel tree? If it does, then is
    > it produced from one of the Xilinx reference designs? Can you add
    > documentation to the header that specifies exactly which design
    > version this .dts is for?

    I think there's value in having a generic DTS as an example or
    template, even if it doesn't correspond to any specific machine.
    Agreed a comment block explaining this is valuable.

    I'd almost oppose any attempt to include a standard DTS for things
    like ML401 boards etc - they are just misleading. Unless we do MD5
    hashes on MHS files, and use them as the filenames, any attempt to
    define a standard platform will just fail and confuse people. Better
    to show them how to generate the DTS for their system.

    >> +/*
    >> + * (C) Copyright 2007-2008 Xilinx, Inc.
    >> + * (C) Copyright 2007-2008 Michal Simek
    >> + *
    >> + * Michal SIMEK <monstr@monstr.eu>
    >
    > If this is a generated file, then is this copyright notice even appropriate?

    I agree. I think Michal is just copying Xilinx's habit of putting
    copyright headers in generated files, and it's one that we should stop
    now.

    Regards,

    John
    _______________________________________________
    Linuxppc-dev mailing list
    Linuxppc-dev@ozlabs.org
    https://ozlabs.org/mailman/listinfo/linuxppc-dev




    \
     
     \ /
      Last update: 2008-06-30 08:55    [W:4.734 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site