lkml.org 
[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/34] AMD IOMMU: add header file for driver data structures and defines

* FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:

> > > > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> > > > ---
> > > > include/asm-x86/amd_iommu_types.h | 242 +++++++++++++++++++++++++++++++++++++
> > > > 1 files changed, 242 insertions(+), 0 deletions(-)
> > > > create mode 100644 include/asm-x86/amd_iommu_types.h
> > >
> > > Is necessary to make this file visible to everyone by putting this in
> > > include/asm?
> >
> > The alternative was to put this file in arch/x86/kernel/. But I don't
> > think its the right place for include files. We have include/ for that.
>
> Hmm, really? It's the right thing in the SCSI subsystem at least. You
> don't need to put a header file having only private stuff in include/.

it's OK to have it in include/asm-x86/ (in fact i'd prefer it to stay
there). It includes hardware API details, etc.

Ingo


\
 
 \ /
  Last update: 2008-06-30 14:25    [W:0.089 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site