Messages in this thread | | | Date | Sun, 29 Jun 2008 14:52:36 +0200 (CEST) | From | Jan Engelhardt <> | Subject | Re: [patch] x86: add compilation checks to pci_unmap_ macros |
| |
On Sunday 2008-06-29 08:22, Matti Linnanvuori wrote: >+#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME) dma_addr_t ADDR_NAME[0]; >+#define DECLARE_PCI_UNMAP_LEN(LEN_NAME) unsigned LEN_NAME[0]; >+#define pci_unmap_addr(PTR, ADDR_NAME) sizeof((PTR)->ADDR_NAME) >+#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL) \ >+ do { break; } while (pci_unmap_addr(PTR, ADDR_NAME))
Mh. If addr_name happens to be non-0 for some reason (like, a typo), then this just introduces a lockup. (Better to have a no-op with a typo than a sudden lockup. Given that these are no-ops means they are deprecated, is not it the case?)
| |