Messages in this thread | | | Date | Thu, 26 Jun 2008 03:06:01 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH 00/16] x86: merge setup_32/64.c |
| |
On Thu, Jun 26, 2008 at 3:02 AM, Ingo Molnar <mingo@elte.hu> wrote: > > * Ingo Molnar <mingo@elte.hu> wrote: > >> x86: rename setup.c to setup_percpu.c > > this brought a build failure: > > arch/x86/kernel/setup.c: In function 'setup_arch': > arch/x86/kernel/setup.c:561: error: implicit declaration of function 'efi_reserve_early' > > 09865f3049050458a5c236e5b4630f137d9b179d is first bad commit > commit 09865f3049050458a5c236e5b4630f137d9b179d > Author: Yinghai Lu <yhlu.kernel@gmail.com> > Date: Wed Jun 25 17:48:14 2008 -0700 > > x86: rename setup.c to setup_percpu.c > > we lost an asm/efi.h include. (which, a bit illogically, is not implicit > via the existing linux/efi.h include.) Fixed below. > > Ingo > > --------------> > commit 9faea5db92f5ff3b39e7b66656f847dcb9618caa > Author: Ingo Molnar <mingo@elte.hu> > Date: Thu Jun 26 12:02:01 2008 +0200 > > x86: build fix > > fix: > > arch/x86/kernel/setup.c: In function 'setup_arch': > arch/x86/kernel/setup.c:561: error: implicit declaration of function 'efi_reserve_early' > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index a3f2263..29f04da 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -79,6 +79,7 @@ > #include <asm/mpspec.h> > #include <asm/setup.h> > #include <asm/arch_hooks.h> > +#include <asm/efi.h> > #include <asm/sections.h> > #include <asm/dmi.h> > #include <asm/io_apic.h>
checkpatch.pl want me to remove that.
YH
| |