Messages in this thread | | | Date | Wed, 25 Jun 2008 17:44:59 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX |
| |
* Bernhard Walle <bwalle@suse.de> wrote:
> * Yinghai Lu [2008-06-24 13:21]: > > > > > it seems we should let the caller to use > > > e820_update_range(start, ULLONG_MAX - size,....) > > > > > > so you don't need to touch this func. > > > > or add sanitary check before using size in this func like > > if (size > ULLONG_MAX - start) > > size = ULLONG_MAX - start; > > > > e820_remove_range need to the same thing > > I like that. I think the complexity should be in the function, and not > in the caller's function.
ok - i'll wait for v2 of these patches, which will have the feedback from Yinghai incorporated - agreed? (Please Cc: Yinghai on the next submission of this series) Thanks,
Ingo
| |