lkml.org 
[lkml]   [2008]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRE: [PATCH 3/14] arch/ia64: Eliminate NULL test and memset after alloc_bootmem
    On Tue, 24 Jun 2008, Luck, Tony wrote:

    > > As noted by Akinobu Mita in patch b1fceac2b9e04d278316b2faddf276015fc06e3b,
    > > alloc_bootmem and related functions never return NULL and always return a
    > > zeroed region of memory. Thus a NULL test or memset after calls to these
    > > functions is unnecessary.
    >
    > There is no commit b1fceac2b9e04d278316b2faddf276015fc06e3b in Linus' tree.

    I am not sure to know how to tell precisely where you are looking, but you
    can find it here:

    http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1fceac2b9e04d278316b2faddf276015fc06e3b


    > In addition the current alloc_bootmem() is a macro that uses __alloc_bootmem
    > which most defintely can return NULL.

    The "return NULL;" at the bottom of __alloc_bootmem is preceded by
    panic("Out of memory");, which I assume cannot return?

    > Is this against -mm or linux-next?

    I pull files from the following git repository:

    git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git

    julia



    \
     
     \ /
      Last update: 2008-06-24 19:59    [W:6.858 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site