lkml.org 
[lkml]   [2008]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.26-rc] ACPI Thermal Zone driver breaks lm-sensors 2 userspace


On Mon, 23 Jun 2008, Robert Hancock wrote:

> Mark M. Hoffman wrote:
> >
> > 1) The bug is in libsensors (2.10), not the kernel.
>
> This doesn't matter. Breaking userspace in such a fashion is severely frowned
> upon unless essentially unavoidable, even if it is just triggering a bug.

I do tend to agree. If it used to work, it should continue to work, even
if it wasn't _meant_ to work.

That's not always 100% possible, but the fact is, neither is updating user
space always possible. The kernel needs to try its best to maintain stable
interfaces, and no, "..but the interface was broken" is _not_ an
acceptable excuse for unbreaking it if it causes problems.

> > - but more importantly -
> >
> > 2) This patch is broken.
>
> You didn't indicate what was wrong with the patch.

Yes. Leaving everybody wondering whether it's just an opinionated
expression of the former problem, or whether there is a real and
understandable reason why it was NACK'ed.

Linus


\
 
 \ /
  Last update: 2008-06-24 05:11    [W:0.087 / U:1.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site