lkml.org 
[lkml]   [2008]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 3/3] vfs: make d_path() consistent across mount operations
Date
On Monday 23 June 2008 16:01:44 Al Viro wrote:
> Umm... I don't see problems with doing that, but I hope you realize that
> the notion of "ever having that name" is not the same as "pathnam
> resolution on that name ever leading to that file" - path_walk() is *NOT*
> atomic wrt rename() (or mount --move, indeed) and it's quite possible to
> walk into subdirectory, have it moved under you, then see .. as the next
> pathname component and step out into new parent.

Yes, that's understood. Relative lookups don't visit all
directories up to the root (unless via ".."), so there can be
infinite time between walking down a directory and computing
a pathname for it.

> Said that, it makes sense to avoid dropping/regaining the lock in that
> case - it's less work and I don't believe that it would increase contention
> on vfsmount_lock. So I'm applying that one, just be careful with
> assumptions about consistency, etc. in the general area.

Thanks.

Andreas


\
 
 \ /
  Last update: 2008-06-23 16:53    [W:0.034 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site