Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] module: reorder struct module to save space on 64 bit builds | Date | Mon, 23 Jun 2008 13:14:14 +1000 |
| |
On Sunday 22 June 2008 03:26:15 Denys Vlasenko wrote: > On Friday 20 June 2008 16:44, Richard Kennedy wrote: > > reorder struct module to save space on 64 bit builds. > > saves 1 cacheline_size (128 on default x86_64 & 64 on AMD > > Opteron/athlon) when CONFIG_MODULE_UNLOAD=y. > > > > Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk> > > --- > > > > Patch against 2.6.26-rc6. tested & running successfully on AMD64 desktop > > machine. This patch reduces the data segment of each module by 1 > > cacheline size. > > > > I also compiled with this patch for 32 bit & there was no change in > > size. > > Sometime ago I did something similar. I also shrank the struct module > by ifdefing out fields which are not needed. > > The patch appeared to fell through the cracks. > > Here is it again with original submission text.
Thanks, I've put this in my tree. There's some other module work going on, so it might need a little rework.
Cheers, Rusty.
| |