Messages in this thread | | | Date | Mon, 23 Jun 2008 09:30:58 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [Experimental][PATCH] putback_lru_page rework |
| |
On Sat, 21 Jun 2008 17:56:17 +0900 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > Quick update: > > > > With this patch applied, at ~ 1.5 hours into the test, my system panic'd > > [panic_on_oops set] with a BUG in __find_get_block() -- looks like the > > BUG_ON() in check_irqs_on() called from bh_lru_install() inlined by > > __find_get_block(). Before the panic occurred, I saw warnings from > > native_smp_call_function_mask() [arch/x86/kernel/smp.c]--also because > > irqs_disabled(). > > > > I'll back out the changes [spin_[un]lock() => spin_[un]lock_irq()] to > > shrink_inactive_list() and try again. Just a hunch. > > Yup. > Kamezawa-san's patch remove local_irq_enable(), but don't remove > local_irq_disable(). > thus, irq is never enabled. >
Sorry, -Kame
> > - spin_unlock(&zone->lru_lock); > > + spin_unlock_irq(&zone->lru_lock); > > done: > > - local_irq_enable(); > > >
| |