lkml.org 
[lkml]   [2008]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calculation

    * Alok Kataria <akataria@vmware.com> wrote:

    > loops_per_jiffy = preset_lpj;
    > - printk("Calibrating delay loop (skipped)... "
    > - "%lu.%02lu BogoMIPS preset\n",
    > - loops_per_jiffy/(500000/HZ),
    > - (loops_per_jiffy/(5000/HZ)) % 100);
    > + printk(KERN_DEBUG "Calibrating delay loop skipped, "
    > + "using preset value.. ");

    i dont think the message should be eliminated from default logs via
    making it KERN_DEBUG - this message is a common pattern people watch out
    for and it does give an indication about various sorts of
    timing/performance trouble.

    also, if you break a line like hat i'd suggest to do it like this:

    > + printk(KERN_DEBUG
    > + "Calibrating delay loop skipped, using preset value.. ");

    so that the string remains on a single line.

    Ingo


    \
     
     \ /
      Last update: 2008-06-20 13:43    [W:16.013 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site