lkml.org 
[lkml]   [2008]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction
Ingo Molnar wrote:
> * Ingo Molnar <mingo@elte.hu> wrote:
>
>
>> * Linus Torvalds <torvalds@linux-foundation.org> wrote:
>>
>>
>>> On Thu, 19 Jun 2008, Ingo Molnar wrote:
>>>
>>>> Below is the commit, it needed a small amount of massaging to apply the
>>>> void * -> unsigned long * change in the x86/bitops topic.
>>>>
>>> Well, that's your bug right there.
>>>
>>> The macros very much depended on the pointers being "void *", due to
>>> the pointer arithmetic (which is a gcc extension that we use
>>> extensively - "void *" arithmetic works as if it was a byte
>>> pointer).
>>>
>> duh, yeah - of course. Will retry with that fixed :)
>>
>
> yep, the patch below got it all going and it passed 5 hours of testing
> already. Thanks,
>

Blows up on "gcc version 3.4.4 20050314 (prerelease) (Debian 3.4.3-13)":

CC init/main.o
include2/asm/bitops.h: In function `start_kernel':
include2/asm/bitops.h:59: warning: asm operand 1 probably doesn't match constraints
include2/asm/bitops.h:59: warning: asm operand 1 probably doesn't match constraints
include2/asm/bitops.h:59: warning: asm operand 1 probably doesn't match constraints
include2/asm/bitops.h:59: error: impossible constraint in `asm'
include2/asm/bitops.h:59: error: impossible constraint in `asm'
include2/asm/bitops.h:59: error: impossible constraint in `asm'

J




\
 
 \ /
  Last update: 2008-06-20 21:09    [W:0.062 / U:3.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site