lkml.org 
[lkml]   [2008]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC] remove irqs_disabled warning from local_bh_enable

* Michael Buesch <mb@bu3sch.de> wrote:

> On Friday 20 June 2008 17:27:48 Ingo Molnar wrote:
> > [<c012b361>] local_bh_enable_ip+0xd1/0xe0
> > [<c08d9f9f>] _spin_unlock_bh+0x2f/0x40
> > [<c0471b92>] vortex_timer+0xe2/0x3e0
>
> > real bug or false positive?
>
> Well, a timer runs with IRQs disabled, no? So this would be a bug.

indeed - agreed :) [no time for me to fix it, but can test any rfc patch.]

so score +1 for Johannes's patch. I think if it works out fine and there
are no false positives in further testing i'll put it up for pull into
v2.6.26 as well, as it is catching real bugs.

Ingo


\
 
 \ /
  Last update: 2008-06-20 18:01    [W:0.092 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site