lkml.org 
[lkml]   [2008]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Unify crashkernel reservation for 32 and 64 bit

* Bernhard Walle <bwalle@suse.de> wrote:

> > famous last words :)
> >
> > can you see any functionality difference between them? If yes, that
> > should be declared.
>
> The only difference was the calculation of memory -- it's more
> complicated on i386 because of high memory support, so that was
> outsourced to an inline function. However, because the highmem is in
>
> #ifdef CONFIG_HIGHMEM
> #endif
>
> and CONFIG_HIGHMEM is off on x86-64, that doesn't matter. Do you see
> another issue?

i can see no issue, i was just was confused a bit by the "more or less"
qualifier.

I've applied your patch to tip/x86/mpparse, thanks Bernhard.

> I tested it on both x86-64 and i386, with CONFIG_KEXEC on and off (so
> that it compiles).

that's always good to know - it's useful to know the amount and scope of
testing - i've put this into the changelog.

Ingo


\
 
 \ /
  Last update: 2008-06-20 16:39    [W:0.034 / U:2.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site