lkml.org 
[lkml]   [2008]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC] remove irqs_disabled warning from local_bh_enable

* Johannes Berg <johannes@sipsolutions.net> wrote:

> Subject: clean up and comment local_bh_enable code
>
> There's no need to use local_irq_save() over local_irq_disable() in
> the local_bh_enable code since it is a bug to call it with irqs
> disabled and do_softirq will enable irqs if there is any pending work.
> Consolidate the code from local_bh_enable and ..._ip to avoid having a
> disconnect between them in the warnings they trigger that is currently
> there. Also always trigger the warning on in_irq(), not just in the
> trace-irqflags case.

applied to tip/core/softirq for testing, thanks Johannes.

Ingo


\
 
 \ /
  Last update: 2008-06-20 15:51    [W:0.063 / U:2.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site