Messages in this thread | | | Date | Mon, 2 Jun 2008 02:05:09 -0400 | From | Christoph Hellwig <> | Subject | Re: [patch 8/8] vfs: create file_remove_suid() helper |
| |
On Sun, Jun 01, 2008 at 10:45:30PM +0200, Miklos Szeredi wrote: > Which means, that that pointer dereference will be done once instead > of in each caller, no? It's a gain (albeit a small one) is in code > cleanliness, and possibly in generated code size.
Again, it doesn't make anyhing simpler. It might be a cleanup at best. I don't really care too much about this one because we could easily change it back in case a caller appear that just has the inode, but the tone you set here defintively doesn't help getting these trivial patches without real gain in :)
| |