Messages in this thread | | | Date | Wed, 18 Jun 2008 16:56:58 +0200 | From | Stefan Richter <> | Subject | Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg_constant |
| |
> On Wed, Jun 18, 2008 at 3:09 PM, Dmitri Vorobiev > <dmitri.vorobiev@movial.fi> wrote: >> Paolo Ciarrocchi wrote: >>> >>> -static void fld_const(FPU_REG const *c, int adj, u_char tag) >>> +static void fld_const(FPU_REG const * c, int adj, u_char tag) >> ________________________________________^ >> >> The above does not seem to me like a big improvement in code quality. A >> false positive from checkpatch.pl?
It should obviously be
static void fld_const(const FPU_REG *c, int adj, u_char tag)
FPU_REG is not an appropriate type name though. Is "typedef struct fpu__reg FPU_REG;" necessary at all? (Removing it would create some code churn all over x86/math-emu/ though. Maybe not desirable.) -- Stefan Richter -=====-==--- -==- =--=- http://arcgraph.de/sr/
| |