Messages in this thread | | | Date | Wed, 18 Jun 2008 16:01:21 +0200 | From | Maxim Shchetynin <> | Subject | Re: AZFS file system proposal |
| |
I have updated my patch and will post it here in a few minutes. Thank you very much Dmitri, all your comments are useful.
> > +static unsigned long > > +azfs_recherche(struct inode *inode, enum azfs_direction direction, > > At the risk of being damned by the entire francophone world, I'd still > suggest using an English keyword for the function name here.
Fixed.
> > +static struct inode* > > +azfs_new_inode(struct super_block *, struct inode *, int, dev_t); > > Would it not be better to place this function prototype along with the > bunch of macro definitions you have above into a private header?
I have a pretty few such definitions and would like to avoid adding to kernel an unnecessary .h file with just a couple of lines.
> > + if (rc == 0) > > Maybe "if (!rc)" ?
Not critical, but fixed.
> > + void *ziel; > > void *target?
Fixed.
> > + void *quell; > > void *source?
Fixed.
> > + struct azfs_block *block, *ding, *knoten, *west, *east; > > The risk of me getting damned increases with that, but maybe it would be > better to use an English keyword for "knoten"?
Fixed.
> > + struct azfs_super *super, *SUPER; > > I think that yelling in deep desperation like that is not quite in > agreement with the kernel coding style.
Fixed.
> An unprecedented lack of comments in this driver can hardly boost the > reader's attention. Besides, I personally think that a kind of a design > document could be extremely useful - basically, explain the purpose of > the filesystem, the basic idead behind it, etc.
I have added Documentation/filesystems/azfs.txt file with a short description of what AZFS is.
-- Mit freundlichen Grüßen / met vriendelijke groeten / avec regards
Maxim V. Shchetynin Linux Kernel Entwicklung IBM Deutschland Entwicklung GmbH Linux für Cell, Abteilung 3250 Schönaicher Straße 220 71032 Böblingen
Vorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Sitz der Gesellschaft: Böblingen Registriergericht: Amtsgericht Stuttgart, HRB 243294
Fahr nur so schnell wie dein Schutzengel fliegen kann! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |