lkml.org 
[lkml]   [2008]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: architectures with ARCH_SUPPORTS_AOUT but no binfmt_aout
    On Tue, Jun 17, 2008 at 12:28:33PM +0100, David Woodhouse wrote:
    > On Tue, 2008-06-17 at 13:11 +0300, Adrian Bunk wrote:
    > > The pattern for this stuff is to provide a HAVE_AOUT kconfig variable
    > > that gets select'ed by these architectures.
    >
    > http://git.infradead.org/users/dwmw2/aout-2.6.git?a=commitdiff;h=a5db5179
    >
    > Subject: [PATCH] Introduce HAVE_AOUT symbol to remove hard-coded arch list for BINFMT_AOUT
    >
    > HAVE_AOUT doesn't quite do the same thing as the recently removed
    > ARCH_SUPPORTS_AOUT config option. That was set even on platforms where
    > binfmt_aout isn't supported, although it's not entirely clear why.
    >
    > So it's best just to introduce a new symbol, handled consistently with
    > other similar HAVE_xxx symbols; with a simple 'select' the arch Kconfig.

    Looks good.
    One minor issue...


    > @@ -7,6 +7,7 @@ config ALPHA
    > default y
    > select HAVE_IDE
    > select HAVE_OPROFILE
    > + select HAVE_AOUT
    Sorting these alphabetically will result in less merge conflicts when the list grows.

    Sam


    \
     
     \ /
      Last update: 2008-06-17 14:25    [W:3.357 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site