Messages in this thread Patch in this message | | | Date | Wed, 18 Jun 2008 12:33:02 +0900 | From | KOSAKI Motohiro <> | Subject | Re: [PATCH] unevictable mlocked pages: initialize mm member of munlock mm_walk structure |
| |
> PATCH: fix munlock page table walk - now requires 'mm' > > Against 2.6.26-rc5-mm3. > > Incremental fix for: mlock-mlocked-pages-are-unevictable-fix.patch > > Initialize the 'mm' member of the mm_walk structure, else the > page table walk doesn't occur, and mlocked pages will not be > munlocked. This is visible in the vmstats:
Yup, Dave Hansen changed page_walk interface recently. thus, his and ours patch is conflicted ;)
below patch is just nit cleanups.
=========================================== From: Lee Schermerhorn <lee.schermerhorn@hp.com>
This [freeing of mlocked pages] also occurs in unpatched 26-rc5-mm3.
Fixed by the following:
PATCH: fix munlock page table walk - now requires 'mm'
Against 2.6.26-rc5-mm3.
Incremental fix for: mlock-mlocked-pages-are-unevictable-fix.patch
Initialize the 'mm' member of the mm_walk structure, else the page table walk doesn't occur, and mlocked pages will not be munlocked. This is visible in the vmstats:
noreclaim_pgs_munlocked - should equal noreclaim_pgs_mlocked less (nr_mlock + noreclaim_pgs_cleared), but is always zero [munlock_vma_page() never called]
noreclaim_pgs_mlockfreed - should be zero [for debug only], but == noreclaim_pgs_mlocked - (nr_mlock + noreclaim_pgs_cleared)
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
mm/mlock.c | 1 + 1 file changed, 1 insertion(+)
Index: b/mm/mlock.c =================================================================== --- a/mm/mlock.c +++ b/mm/mlock.c @@ -310,6 +310,7 @@ static void __munlock_vma_pages_range(st .pmd_entry = __munlock_pmd_handler, .pte_entry = __munlock_pte_handler, .private = &mpw, + .mm = mm, }; VM_BUG_ON(start & ~PAGE_MASK || end & ~PAGE_MASK);
| |