Messages in this thread | | | Date | Wed, 18 Jun 2008 10:54:00 +0900 | From | Daisuke Nishimura <> | Subject | Re: [PATCH][RFC] fix kernel BUG at mm/migrate.c:719! in 2.6.26-rc5-mm3 |
| |
On Wed, 18 Jun 2008 00:33:18 +0900, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > > @@ -715,13 +725,7 @@ unlock: > > * restored. > > */ > > list_del(&page->lru); > > - if (!page->mapping) { > > - VM_BUG_ON(page_count(page) != 1); > > - unlock_page(page); > > - put_page(page); /* just free the old page */ > > - goto end_migration; > > - } else > > - unlock = putback_lru_page(page); > > + unlock = putback_lru_page(page); > > } > > > > if (unlock) > > this part is really necessary? > I tryed to remove it, but any problem doesn't happend. > I made this part first, and added a fix for migration_entry_wait later.
So, I haven't test without this part, and I think it will cause VM_BUG_ON() here without this part.
Anyway, I will test it.
> Of cource, another part is definitly necessary for specurative pagecache :) >
| |