Messages in this thread | | | Date | Tue, 17 Jun 2008 09:04:15 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: merge setup_memory_map with e820 |
| |
Glauber Costa wrote: >> + boot_params.e820_entries = new_nr; >> + if (copy_e820_map(boot_params.e820_map, boot_params.e820_entries) < 0) { >> +#ifdef CONFIG_X86_64 >> + early_panic("Cannot find a valid memory map"); >> +#else > > Can't this be made dependant on HIGHMEM instead of X86_64? It seems > high-memory dependant anyway. Also, are you sure > this code that maps into himem would work with HIGHMEM disabled anyway? >
Uhm... x86-64 and HIGHMEM are mutually exclusive.
Either way, it shouldn't be dependent on anything; there is no reason why the #else clause can't be applied to both.
-hpa
| |