lkml.org 
[lkml]   [2008]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: merge setup_memory_map with e820
Glauber Costa wrote:
>> + boot_params.e820_entries = new_nr;
>> + if (copy_e820_map(boot_params.e820_map, boot_params.e820_entries) < 0) {
>> +#ifdef CONFIG_X86_64
>> + early_panic("Cannot find a valid memory map");
>> +#else
>
> Can't this be made dependant on HIGHMEM instead of X86_64? It seems
> high-memory dependant anyway. Also, are you sure
> this code that maps into himem would work with HIGHMEM disabled anyway?
>

Uhm... x86-64 and HIGHMEM are mutually exclusive.

Either way, it shouldn't be dependent on anything; there is no reason
why the #else clause can't be applied to both.

-hpa




\
 
 \ /
  Last update: 2008-06-17 18:07    [W:0.092 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site