Messages in this thread |  | | Date | Mon, 16 Jun 2008 16:02:16 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] ip2: use request_firmware() |
| |
Alan Cox wrote: > On Mon, 16 Jun 2008 10:49:11 +0100 > David Woodhouse <dwmw2@infradead.org> wrote: > >> Converted with help from Jaswinder Singh >> >> Signed-off-by: David Woodhouse <dwmw2@infradead.org> >> --- >> drivers/char/Kconfig | 7 + >> drivers/char/ip2/fip_firm.h | 2149 ---------------------------------------- >> drivers/char/ip2/ip2base.c | 5 +- >> drivers/char/ip2/ip2main.c | 45 +- >> firmware/Makefile | 1 + >> firmware/WHENCE | 10 + >> firmware/intelliport2.bin.ihex | 2147 +++++++++++++++++++++++++++++++++++++++ >> 7 files changed, 2201 insertions(+), 2163 deletions(-) >> delete mode 100644 drivers/char/ip2/fip_firm.h >> create mode 100644 firmware/intelliport2.bin.ihex > > Fine by me. I've not checked all the digits are correct but the rest of > the logic seems clean enough > > Acked-by: Alan Cox <alan@redhat.com>
Except for the part where the firmware is pointlessly separated from the driver.
We do not need two parallel driver hierarchies, one for firmware, one for C source.
Jeff
|  |