[lkml]   [2008]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] 8139too: clean up spaces and TABs
Németh Márton wrote:
> I have chosen the's output to compare the
> whether the old and the new code are better or not. Maybe that was a mistake.

Well, running checkpatch on source files (rather than patches) and
fixing the files up according to checkpatch's output and own good
judgement has two uses:
- bring new unmerged code into shape before submission,
- bring older mainline code into the canonical form as a basis
for further work. You certainly saw how lots and lots of such
checkpatch-assisted cleanups went into arch/x86. That's because
they were found useful for the work on unifying the two x86
architecture subtrees.
So, a coding style rework has its use even on legacy code if people have
plans with the code. But keep in mind that (a) the whitespace rules
aren't hard and universally agreed upon rules, (b) coding style has a
number of other aspects of arguably greater importance than whitespace
style, like proper modularization, good choices of names, use of common
idioms and APIs instead of own inventions, and so on.
Stefan Richter
-=====-==--- -==- =----
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2008-06-16 17:13    [W:0.081 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site