[lkml]   [2008]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/3] relay: Add buffer-only channels; useful for early logging.
* Eduard - Gabriel Munteanu ( wrote:
> On Fri, 13 Jun 2008 10:04:57 +0300
> Pekka Enberg <> wrote:
> > Why do we need to change for_each_online_cpu to for_each_present_cpu?
> > I guess it's because we don't have all the CPUs online at early
> > boot?
> Yes, that's true. Only one CPU is online at that early point.
> > Wouldn't it then be better to implement CPU hotplug support
> > instead?
> It's difficult for me to write such code, as I'm unable to test CPU
> hotplug; my machines are a Turion X2 laptop and a Athlon Barton desktop
> computer. So I can't turn off, or unplug in a software sense, one CPU core.
> Correct me if I'm wrong, but I don't see any way to do that in /sys/devices/system/cpu/

See Documentation/cpu-hotplug.txt

If you need to "emulate" having many CPUs, Xen is always an option.

> But I suppose I could write a patch very carefully, and then submit to
> someone that can test this. Anyway, I'll look into this and try to
> understand the code without being able to test.

Hrm, sounds like a bad idea... please try getting a test setup working,
it will save you a gazillion iterations and let you stress-test your


> Eduard

Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

 \ /
  Last update: 2008-06-16 14:33    [W:0.266 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site