Messages in this thread |  | | Subject | Re: [PATCH v2] export linux/a.out.h | From | David Woodhouse <> | Date | Mon, 16 Jun 2008 13:26:54 +0100 |
| |
On Mon, 2008-06-16 at 15:17 +0300, Adrian Bunk wrote: > On Mon, Jun 16, 2008 at 01:01:03PM +0100, David Woodhouse wrote: > >... > > David Woodhouse (6): > >... > > Remove references to now-defunct CONFIG_ARCH_SUPPORTS_AOUT from defconfigs > > Please don't do this kind of defconfig updates - it doesn't bring any > advantage but can create tons of patch conflicts. > > The next time a defconfig gets updated it will anyway automatically be > fixed, and for defconfigs that aren't updated it doesn't create any > problems to keep them as they are today until they might one day get > updated.
OK. I did wonder about that, which is why I did it in a separate patch.
Actually, I think we can drop the preceding patch too -- it's not necessary to fix the regression in 2.6.26, and dhowells suggests that we might still want to use ARCH_SUPPORTS_AOUT, by making BINFMT_AOUT depend on it instead of that hard-coded list of architectures.
If we do that, then ARCH_SUPPORTS_AOUT would need to be defined on a different set of architectures to the ones it's currently defined on -- so I don't really want to go there before 2.6.26. I'll push just the parts which were included in the mail I just sent.
Why _are_ there architectures which define ARCH_SUPPORTS_AOUT and have <asm/a.out.h> but don't support binfmt_aout, anyway? How does that make sense?
-- dwmw2
|  |