Messages in this thread |  | | Subject | Re: [PATCH] ip2: use request_firmware() | From | David Woodhouse <> | Date | Mon, 16 Jun 2008 13:06:19 +0100 |
| |
On Mon, 2008-06-16 at 11:59 +0100, Alan Cox wrote: > On Mon, 16 Jun 2008 10:49:11 +0100 > David Woodhouse <dwmw2@infradead.org> wrote: > > > Converted with help from Jaswinder Singh > > > > Signed-off-by: David Woodhouse <dwmw2@infradead.org> > > --- > > drivers/char/Kconfig | 7 + > > drivers/char/ip2/fip_firm.h | 2149 ---------------------------------------- > > drivers/char/ip2/ip2base.c | 5 +- > > drivers/char/ip2/ip2main.c | 45 +- > > firmware/Makefile | 1 + > > firmware/WHENCE | 10 + > > firmware/intelliport2.bin.ihex | 2147 +++++++++++++++++++++++++++++++++++++++ > > 7 files changed, 2201 insertions(+), 2163 deletions(-) > > delete mode 100644 drivers/char/ip2/fip_firm.h > > create mode 100644 firmware/intelliport2.bin.ihex > > Fine by me. I've not checked all the digits are correct but the rest of > the logic seems clean enough
Yeah, we're trying to be quite careful with the digits, but I'd be a lot happier when some of this actually gets tested.
It's good that Jaswinder is now helping -- we can each convert the firmware and verify that we come up with the same thing. And while I'm giving a lot of guidance on the _code_ changes, I'm deliberately leaving him to his own devices for that part, as a kind of 'control' :)
-- dwmw2
|  |