lkml.org 
[lkml]   [2008]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [BUGFIX] lockdep: output lock_class key instead of address for forward dependency output
From
Date
On Fri, 2008-06-13 at 08:58 +0200, Ingo Molnar wrote:
> * Huang, Ying <ying.huang@intel.com> wrote:
>
> > The key instead of address of lock_class should be output in
> > /proc/lockdep when forward dependency is output, because key is
> > output for lock_class itself as identifier too.
> >
> > This patch is based on x86/auto-latest branch of git-x86 tree, and has
> > been tested on x86_64 platform.
>
> applied to tip/core/locking - thanks Ying.
>
> i'm wondering, can entry->class never be NULL here?

As far as I know, it can never be NULL. Because entry is added into
class->locks_after in following call chain:

lock_acquire -> __lock_acquire -> validate_chain -> check_prevs_add ->
check_prev_add -> add_lock_to_list

in __lock_acquire the lock_class is look up or registered from
lockdep_map and put in held_lock, which is used in following function in
call chain.

Best Regards,
Huang Ying



\
 
 \ /
  Last update: 2008-06-13 09:27    [W:0.041 / U:1.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site