lkml.org 
[lkml]   [2008]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Bug 10866] /dev/rtc was missing until I disabled CONFIG_RTC_CLASS

* David Brownell <david-b@pacbell.net> wrote:

> On Friday 13 June 2008, Lior Dotan wrote:
> > I don't know if it helps you to decide but the way I got to this
> > configuration is by copying my working 2.6.25 .config file and running
> > make oldconfig. I think this scenario is common when upgrading to a
> > newer version so you should make sure it doesn't generate an invalid
> > configuration.
>
> It doesn't! "No /dev/rtc" is a perfectly valid config. [...]

The bug scenario is rather simple: /dev/rtc existed with that config in
prior kernels and now, after "make oldconfig" it does not exist, it's a
plain regression and must be fixed.

> And it's not uncommon that new kernels require config tweaks.

that's wrong - 'make oldconfig' must work smoothly and in an expected
way.

If you argue that the new kernel should come up with a non-existent
/dev/rtc, then you are wrong and you go against established regression
handling policies of the kernel. Smooth migration via "make oldconfig"
is a must, otherwise we'd lose testers and users.

The old /dev/rtc might indeed have been unbelievably "bad" in various
ways and you dont even want to think about that code now, but it's your
code now that is used so you might as well think about the other 98% of
users who used the old /dev/rtc with old kernels. (not because they
wanted to use bad code, but because simply that was the default)

Ingo


\
 
 \ /
  Last update: 2008-06-13 23:07    [W:0.107 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site