Messages in this thread | | | Date | Fri, 13 Jun 2008 20:16:27 +0200 | From | Robert Richter <> | Subject | Re: [PATCH 2/2] x86: Move PCI IO ECS code to x86/pci |
| |
On 13.06.08 14:02:46, Glauber Costa wrote: > > diff --git a/arch/x86/pci/amd_bus.c b/arch/x86/pci/amd_bus.c > > index 5c2799c..15f505d 100644 > > --- a/arch/x86/pci/amd_bus.c > > +++ b/arch/x86/pci/amd_bus.c > > @@ -1,5 +1,9 @@ > > #include <linux/init.h> > > #include <linux/pci.h> > > +#include "pci.h" > > + > > +#ifdef CONFIG_X86_64 > > Please, don't do that. We are in an ongoing effort to cleanup the > remaining ifdefs in x86 code, and adding more of them would just make > it harder. > If you really need it, move the common part to a separate file (avoid > the _32 and _64 naming), and have it compiled conditionally on your > architecture.
Ok, so what about shared code? Keep all this in separate files: amd_bus.c, (amd_bus_32.c), amd_bus_64.c, (amd_bus.h)?
Is the strategy to avoid #ifdefs and instead use the flags in Makefiles? My intention was to coalesce the files. Maybe I was wrong here.
-Robert
-- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@amd.com
| |