Messages in this thread | | | Date | Tue, 10 Jun 2008 09:58:25 -0700 | From | Arthur Jones <> | Subject | Re: on static kobjects and double frees... |
| |
Hi Greg, ...
On Tue, Jun 10, 2008 at 09:42:41AM -0700, Greg KH wrote: > > [...] > > OK, I wondered about this, but I didn't see anything > > in Documentation/kobject.txt that said that kobjects > > can not be static. But now that I've fixed the double > > free bug, I'm seeing the warning you mentioned above... > > Hm, there is the following text in that file: > Because kobjects are dynamic, they must not be declared > statically or on the stack, but instead, always allocated > dynamically. Future versions of the kernel will contain a > run-time check for kobjects that are created statically and will > warn the developer of this improper usage.
Indeed, I see that now. Sorry for the noise, I should have read more carefully...
> > I don't know how the current code came to be, so I > > can't speak to your issues below. But, with these > > pointers, I think I can get things cleaned up properly. > > Great, if you want me to review it, I'd be glad to do so.
Thanks!
Arthur
| |