lkml.org 
[lkml]   [2008]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: on static kobjects and double frees...
Hi Greg, ...

On Tue, Jun 10, 2008 at 09:42:41AM -0700, Greg KH wrote:
> > [...]
> > OK, I wondered about this, but I didn't see anything
> > in Documentation/kobject.txt that said that kobjects
> > can not be static. But now that I've fixed the double
> > free bug, I'm seeing the warning you mentioned above...
>
> Hm, there is the following text in that file:
> Because kobjects are dynamic, they must not be declared
> statically or on the stack, but instead, always allocated
> dynamically. Future versions of the kernel will contain a
> run-time check for kobjects that are created statically and will
> warn the developer of this improper usage.

Indeed, I see that now. Sorry for the noise, I should
have read more carefully...

> > I don't know how the current code came to be, so I
> > can't speak to your issues below. But, with these
> > pointers, I think I can get things cleaned up properly.
>
> Great, if you want me to review it, I'd be glad to do so.

Thanks!

Arthur


\
 
 \ /
  Last update: 2008-06-10 19:01    [W:0.054 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site