Messages in this thread | | | Date | Sun, 1 Jun 2008 13:25:46 +0400 | From | Alexey Dobriyan <> | Subject | Re: [PATCH] drm: make drm use create_proc_read_entry() instead |
| |
On Sat, May 31, 2008 at 09:48:21PM -0700, Arjan van de Ven wrote: > Subject: [PATCH] drm: make drm use create_proc_read_entry() instead > > Al Viro points out that DRM should have used create_proc_read_entry(), > and although that is still racey right now, it at least has a chance > of getting fixed on the api level.
Fix on API level is proc_create_data(), so this patch is pointless.
> --- a/drivers/char/drm/drm_proc.c > +++ b/drivers/char/drm/drm_proc.c > @@ -102,8 +102,9 @@ int drm_proc_init(struct drm_minor *minor, int minor_id, > } > > for (i = 0; i < DRM_PROC_ENTRIES; i++) { > - ent = create_proc_entry(drm_proc_list[i].name, > - S_IFREG | S_IRUGO, minor->dev_root); > + ent = create_proc_read_entry(drm_proc_list[i].name, > + S_IFREG | S_IRUGO, minor->dev_root, > + drm_proc_list[i].f, minor); > if (!ent) { > DRM_ERROR("Cannot create /proc/dri/%s/%s\n", > name, drm_proc_list[i].name); > @@ -114,8 +115,6 @@ int drm_proc_init(struct drm_minor *minor, int minor_id, > minor->dev_root = NULL; > return -1; > } > - ent->read_proc = drm_proc_list[i].f; > - ent->data = minor; > }
| |