lkml.org 
[lkml]   [2008]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 07/24] fat: dont call notify_change
From
Date
> > From: Miklos Szeredi <mszeredi@suse.cz>
> >
> > The FAT_IOCTL_SET_ATTRIBUTES ioctl() calls notify_change() to change
> > the file mode before changing the inode attributes. Replace with
> > explicit call to fat_setattr().
> >
> > This is equivalent, except that security_inode_setattr() is not called
> > before fat_setattr(). I think this is not needed, since the mode
> > change is just a side effect of the attribute change.
>
> Actually I think we want the security_inode_setattr. This is an
> implicit chmode when switching the ATTR_RO flag on and off and we should
> have the full security check for it.

Yes, I'm a bit uncertain about this. It's a user action that triggers
the mode change. On the other hand it's just a side effect of the
ioctl. I can re-add the security check just to be on the safe side,
but probably nobody cares.

Miklos


\
 
 \ /
  Last update: 2008-05-08 20:55    [W:0.045 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site