Messages in this thread | | | From | David Brownell <> | Subject | Re: [PATCH] gpio: fix build errors for drivers not strictly requiring GPIOs | Date | Thu, 29 May 2008 20:28:10 -0700 |
| |
On Tuesday 27 May 2008, Anton Vorontsov wrote: > Since commit 7560fa60fcdcdb0da662f6a9fad9064b554ef46c (gpio: <linux/gpio.h> > and "no GPIO support here" stubs) drivers can use GPIOs if they're available, > but don't require them. > > This patch actually enables this feature, otherwise drivers will stumble > against this: > > include/asm-generic/gpio.h:111: error: redefinition of 'gpio_is_valid' > include/linux/gpio.h:21: error: previous definition of 'gpio_is_valid' was here
This looks to me like pure user error ... what was anyone doing including <asm-generic/gpio.h> in that way? There are a *lot* of bogus include combinations, and we don't try to "fix" them.
It should suffice to #include <linux/gpio.h> ... that causes the definition of either (a) stubs in that file, *OR* else (b) the platform-specific implementation of the GPIO calls, which may (if that platform chooses) use <asm-generic/gpio.h> utilities.
NAK on this patch.
- dave
| |