Messages in this thread | | | Date | Fri, 30 May 2008 00:18:14 -0400 | From | "Mike Frysinger" <> | Subject | Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB |
| |
On Thu, May 29, 2008 at 5:29 PM, Christoph Lameter wrote: > On Thu, 29 May 2008, Mike Frysinger wrote: >> > You should not have to do this. This is the default alignment that also >> > SLOB needs to follow. We need to align structures correctly for access to >> > long long's. >> >> are you saying that slob is broken ? i see in mm/slob.c: >> #ifndef ARCH_KMALLOC_MINALIGN >> #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long) >> #endif > > It should be long long instead. > > SLUB: > > #ifndef ARCH_KMALLOC_MINALIGN > #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long) > #endif > > SLAB: > > #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)
will you post a patch to do that (and ideally delete all of the occurrences in asm-*/ where the minalign is defined to 8) ? -mike
| |