lkml.org 
[lkml]   [2008]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[DEVICE MODEL] dev->dma_mask
On 30-05-08 23:15, Rene Herman wrote:

On ...

> @@ -167,6 +168,9 @@ struct pnp_card *pnp_alloc_card(struct pnp_protocol *protocol, int id, char *pnp
> sprintf(card->dev.bus_id, "%02x:%02x", card->protocol->number,
> card->number);
>
> + card->dev.coherent_dma_mask = DMA_24BIT_MASK;
> + card->dev.dma_mask = &card->dev.coherent_dma_mask;
> +
> dev_id = pnp_add_card_id(card, pnpid);
> if (!dev_id) {
> kfree(card);
>

... this note by the way I believe pnp_dev might as well get rid of its
dma_mask as well. As far I've googled up the history of that the reason
why dev->dma_mask is a pointer is only that it's been moved into struct
device from struct pci_dev where the latter location was kept as the
main one so as to not upset then current code.

Everyone else seems to have then faithfully cloned pci_dev and stuck it
in their private structs as well but for no good reason it would appear.

And in the case of the PnP ISA masks, we're talking about constant
masks, dictated by the shared global DMA controller and not the card
itself (there are a few ISA cards that do their own busmastering but
they're special) so the mask might as well just point to the coherent mask.

Unless I'm missing something ofcourse...

Rene.


\
 
 \ /
  Last update: 2008-05-30 23:27    [W:0.097 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site