Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/2] OF: Fix coding style violation in of_device.c and of_platform.c | Date | Sat, 3 May 2008 23:04:57 +0200 |
| |
On Saturday 03 May 2008, monstr@seznam.cz wrote:
> > #include <asm/errno.h> > + > +#ifdef CONFIG_PPC_PSERIES > #include <asm/dcr.h> > +#endif >
The patch looks basically good, but we normally try to not have an #include inside of #ifdef. If the file builds without this #include, maybe you should better leave it out entirely? Same for the ppc-pci.h in the other file.
Arnd <><
| |