lkml.org 
[lkml]   [2008]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] OF: Fix coding style violation in of_device.c and of_platform.c
Date
On Saturday 03 May 2008, monstr@seznam.cz wrote:

>
> #include <asm/errno.h>
> +
> +#ifdef CONFIG_PPC_PSERIES
> #include <asm/dcr.h>
> +#endif
>

The patch looks basically good, but we normally try to not have an #include
inside of #ifdef. If the file builds without this #include, maybe you should
better leave it out entirely? Same for the ppc-pci.h in the other file.

Arnd <><


\
 
 \ /
  Last update: 2008-05-03 23:07    [W:0.093 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site