lkml.org 
[lkml]   [2008]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] OF: clean coding style - prom_parse.c
From
Date
On Sat, 2008-05-03 at 17:13 +0200, monstr@seznam.cz wrote:
> /* Debug utility */
> #ifdef DEBUG
> static void of_dump_addr(const char *s, const u32 *addr, int na)
> {
> - printk("%s", s);
> - while(na--)
> - printk(" %08x", *(addr++));
> - printk("\n");
> + printk(KERN_INFO "%s", s);
> + while (na--)
> + printk(KERN_INFO " %08x", *(addr++));
> + printk(KERN_INFO "\n");
> }

You've prefixed KERN_INFO before every address block.

How about:

print_hex_dump(KERN_<level>, s, DUMP_PREFIX_NONE, 4, addr, na, false);



\
 
 \ /
  Last update: 2008-05-03 19:29    [W:0.050 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site