lkml.org 
[lkml]   [2008]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: RESEND: [PATCH 3/3] Misc: Add HP WMI laptop extras driver
On Wed, May 28, 2008 at 10:42:00PM -0700, Andrew Morton wrote:
> On Wed, 28 May 2008 14:34:25 +0100 Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > --- /dev/null
> > +++ b/drivers/misc/hp-wmi.c
>
> I see no Kconfig or Makefile updates.

Oops. Will resend.

> > +static struct key_entry hp_wmi_keymap[] = {
> > + {KE_SW, 0x01, SW_DOCK},
> > + {KE_KEY, 0x02, KEY_BRIGHTNESSUP},
> > + {KE_KEY, 0x03, KEY_BRIGHTNESSDOWN},
> > + {KE_KEY, 0x04, KEY_HELP},
> > + {KE_END, 0}
> > +};
>
> Could be made const. hp_wmi_input_setup() already honours that,
> others will need tweaks.

Not if we want to be able to set the keymap, surely?
--
Matthew Garrett | mjg59@srcf.ucam.org


\
 
 \ /
  Last update: 2008-05-29 10:11    [W:0.160 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site