lkml.org 
[lkml]   [2008]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10 of 12] xen: implement save/restore
Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>
>> This patch implements Xen save/restore and migration.
>>
>
> -tip testing found the following build breakage:
>
> drivers/built-in.o: In function `xen_suspend':
> manage.c:(.text+0x4390f): undefined reference to `xen_console_resume'
>
> with this config:
>
> http://redhat.com/~mingo/misc/config-Thu_May_29_09_23_16_CEST_2008.bad
>
> i have bisected it down to:
>
> | commit 0e91398f2a5d4eb6b07df8115917d0d1cf3e9b58
> | Author: Jeremy Fitzhardinge <jeremy@goop.org>
> | Date: Mon May 26 23:31:27 2008 +0100
> |
> | xen: implement save/restore
>
> the problem is that drivers/xen/manage.c is built unconditionally if
> CONFIG_XEN is enabled and makes use of xen_suspend(), but
> drivers/char/hvc_xen.c, where the xen_suspend() method is implemented,
> is only build if CONFIG_HVC_XEN=y as well.
>
> i have solved this by providing a NOP implementation for xen_suspend()
> in the !CONFIG_HVC_XEN case.
>

Thanks Ingo, looks good.

Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

J


\
 
 \ /
  Last update: 2008-05-29 10:03    [W:0.627 / U:1.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site