Messages in this thread | | | Date | Thu, 29 May 2008 22:19:22 +0100 | From | Alan Cox <> | Subject | Re: RESEND: [PATCH] libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl |
| |
> void ata_sff_pause(struct ata_port *ap) > { > ata_sff_altstatus(); > ndelay(400); > } > > and again, if there is no altstatus register, that's a low-level driver > issue.
This takes away the ability to shoot yourself directly in the foot and replaces it with the ability to shoot yourself in the foot in a more abstract way. The dma_pause case still needs to check as that is the one where you can make an actual mess but yes it certainly cleans up the others.
(Next rev brewing ;))
| |