lkml.org 
[lkml]   [2008]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2 v3] Use structs instead of hardcoded offsets in x86 boot decompressor.
From
Date
On Thu, 2008-05-29 at 11:48 -0700, H. Peter Anvin wrote:
> Kristian Høgsberg wrote:
> >
> > Updated this one to be less intrusive; we just re-#define RM_SCREEN_INFO to
> > access the boot_params struct instead of using the hard-coded offset.
> >
>
> Any reason to leave it in as a macro at all, instead of just
> s/RM_SCREEN_INFO/real_mode->screen_info/g?

Only to keep the patch smaller. Accessing the struct directly is
definitely nicer, I'll do the sed job when I resubmit with the other
patch.

cheers,
Kristian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-05-29 22:01    [W:0.330 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site