Messages in this thread Patch in this message | | | From | Lee Schermerhorn <> | Date | Thu, 29 May 2008 15:51:47 -0400 | Subject | [PATCH 24/25] Mlocked Pages: count attempts to free mlocked page |
| |
From: Lee Schermerhorn <lee.schermerhorn@hp.com>
Against: 2.6.26-rc2-mm1
Allow free of mlock()ed pages. This shouldn't happen, but during developement, it occasionally did.
This patch allows us to survive that condition, while keeping the statistics and events correct for debug.
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
include/linux/vmstat.h | 1 + mm/internal.h | 17 +++++++++++++++++ mm/page_alloc.c | 1 + mm/vmstat.c | 1 + 4 files changed, 20 insertions(+)
Index: linux-2.6.26-rc2-mm1/mm/internal.h =================================================================== --- linux-2.6.26-rc2-mm1.orig/mm/internal.h 2008-05-28 10:12:15.000000000 -0400 +++ linux-2.6.26-rc2-mm1/mm/internal.h 2008-05-28 10:15:20.000000000 -0400 @@ -152,6 +152,22 @@ static inline void mlock_migrate_page(st } } +/* + * free_page_mlock() -- clean up attempts to free and mlocked() page. + * Page should not be on lru, so no need to fix that up. + * free_pages_check() will verify... + */ +static inline void free_page_mlock(struct page *page) +{ + if (unlikely(TestClearPageMlocked(page))) { + unsigned long flags; + + local_irq_save(flags); + __dec_zone_page_state(page, NR_MLOCK); + __count_vm_event(NORECL_MLOCKFREED); + local_irq_restore(flags); + } +} #else /* CONFIG_NORECLAIM_MLOCK */ static inline int is_mlocked_vma(struct vm_area_struct *v, struct page *p) @@ -161,6 +177,7 @@ static inline int is_mlocked_vma(struct static inline void clear_page_mlock(struct page *page) { } static inline void mlock_vma_page(struct page *page) { } static inline void mlock_migrate_page(struct page *new, struct page *old) { } +static inline void free_page_mlock(struct page *page) { } #endif /* CONFIG_NORECLAIM_MLOCK */ Index: linux-2.6.26-rc2-mm1/mm/page_alloc.c =================================================================== --- linux-2.6.26-rc2-mm1.orig/mm/page_alloc.c 2008-05-28 10:12:15.000000000 -0400 +++ linux-2.6.26-rc2-mm1/mm/page_alloc.c 2008-05-28 10:15:20.000000000 -0400 @@ -484,6 +484,7 @@ static inline void __free_one_page(struc static inline int free_pages_check(struct page *page) { + free_page_mlock(page); if (unlikely(page_mapcount(page) | (page->mapping != NULL) | (page_get_page_cgroup(page) != NULL) | Index: linux-2.6.26-rc2-mm1/include/linux/vmstat.h =================================================================== --- linux-2.6.26-rc2-mm1.orig/include/linux/vmstat.h 2008-05-28 10:12:56.000000000 -0400 +++ linux-2.6.26-rc2-mm1/include/linux/vmstat.h 2008-05-28 10:15:44.000000000 -0400 @@ -50,6 +50,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PS NORECL_PGMUNLOCKED, NORECL_PGCLEARED, NORECL_PGSTRANDED, /* unable to isolate on unlock */ + NORECL_MLOCKFREED, #endif #endif NR_VM_EVENT_ITEMS Index: linux-2.6.26-rc2-mm1/mm/vmstat.c =================================================================== --- linux-2.6.26-rc2-mm1.orig/mm/vmstat.c 2008-05-28 10:14:02.000000000 -0400 +++ linux-2.6.26-rc2-mm1/mm/vmstat.c 2008-05-28 10:16:11.000000000 -0400 @@ -769,6 +769,7 @@ static const char * const vmstat_text[] "noreclaim_pgs_munlocked", "noreclaim_pgs_cleared", "noreclaim_pgs_stranded", + "noreclaim_pgs_mlockfreed", #endif #endif #endif
| |