Messages in this thread | | | Date | Thu, 29 May 2008 10:14:32 -0300 | From | "Carlos R. Mafra" <> | Subject | Re: [PATCH 2/2] on_each_cpu(): kill unused 'retry' parameter |
| |
On Thu 29.May'08 at 14:54:29 +0200, Jens Axboe wrote: > On Thu, May 29 2008, Carlos R. Mafra wrote: > > Hi, > > > > Just a naive comment/question: > > > > > - if (on_each_cpu(ipi_imb, NULL, 1, 1)) > > > + if (on_each_cpu(ipi_imb, NULL, 1)) > > > > A few weeks ago I though about removing the second argument > > from on_each_cpu, which is NULL more or less 70% of the time. > > > > Do you think it is possible? > > Have you already thought about it? > > It's the data argument to the function, I highly doubt you can get > rid of that I'm afraid. on_each_cpu() is just a thin wrapper on > top of smp_call_function() so that the caller doesn't have to > care about manually calling on the local CPU. So as long as > smp_call_function() has a data argument, on_each_cpu() should > carry it as well. > > So nope, I don't think that's feasible (or even desired).
Ok, thanks for the reply!
| |