Messages in this thread | | | Date | Wed, 28 May 2008 08:57:42 -0400 | From | Vivek Goyal <> | Subject | Re: [PATCH 2/2] kexec jump -v10: save/restore device state |
| |
On Thu, May 22, 2008 at 05:38:19PM +0800, Huang, Ying wrote:
[..] > Known issues: > > - Can not work with the new devices hibernation operations in > 2.6.26-rc2-mm1 so far. Working on this now. > > - APIC is not put into legacy mode during kexec, so kexec may failed > (no IRQ) if APIC is not put into legacy mode. > > - The suspend/resume callback of device drivers are used to put > devices into quiescent state. This will unnecessarily (possibly > harmfully) put devices into low power state. This is intended to be > solved by separating device quiesce/unquiesce callback from the > device suspend/resume callback. > > - Because the segment number supported by sys_kexec_load is limited, > hibernation image with many segments may not be load. This is > planned to be eliminated by adding a new flag to sys_kexec_load to > make a image can be loaded with multiple sys_kexec_load invoking. > >
These two patches look good to me. I think once you have worked out issues with IOAPIC and generated patches for compatibility with new suspend/resume callbacks, these patches are good enough to get some testing going on in -mm tree.
I will also test out -v10 very soon.
Thanks Vivek
| |