Messages in this thread | | | Date | Wed, 28 May 2008 12:51:04 +0800 | From | Li Zefan <> | Subject | Re: [PATCH] call_usermodehelper() increase reliability |
| |
KOSAKI Motohiro wrote: > Now, call_usermodehelper_setup() uses GFP_ATOMIC. > but it can return NULL _very_ easily. > > GFP_ATOMIC is needed only when we can't sleep. > and, GFP_KERNEL is robust and better. > > thus, I add gfp_mask argument to call_usermodehelper_setup(). > > So, its caller pass below, > > call_usermodehelper() and call_usermodehelper_keys(): > depend on 'wait' argument. > call_usermodehelper_pipe(): > always GFP_KERNEL because always run under process context. > orderly_poweroff(): > pass to GFP_ATOMIC because may run under interrupt context. >
I have no problem with this patch.
Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>
| |