lkml.org 
[lkml]   [2008]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm 07/16] second chance replacement for anonymous pages
On Wed, 28 May 2008 14:36:56 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

> > /*
> > + * Count the referenced anon pages as rotated, to balance pageout
> > + * scan pressure between file and anonymous pages in get_sacn_ratio.
> > + */
> > + if (!file)
> > + zone->recent_rotated_anon += pgmoved;
> > +
>
> Shouldn't 'pgmoved' be cleared to 0 before scanning l_hold?
> It's used to store the result of sc->isolate_pages() before
> scanning l_hold.

It is zeroed 2 statements down.

if (!file)
zone->recent_rotated_anon += pgmoved;

/*
* Now put the pages back on the appropriate [file or anon] inactive
* and active lists.
*/
pagevec_init(&pvec, 1);
pgmoved = 0;

--
All rights reversed.


\
 
 \ /
  Last update: 2008-05-28 15:43    [W:0.073 / U:1.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site